Re: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 26 May 2023 14:59:16 +0100
Cc: dhowells@xxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Alexander Duyck <alexanderduyck@xxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Jiri Benc <jbenc@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <366861a7-87c8-4bbf-9101-69dd41021d07@kili.mountain>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <366861a7-87c8-4bbf-9101-69dd41021d07@kili.mountain>

Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> The "len" variable needs to be signed for the error handling to work
> correctly.
> 
> Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>

References:
- [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
  - From: Dan Carpenter

Prev by Date: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
Next by Date: Re: [PATCH] drm/i915/selftests: fix an error code in copy()
Previous by thread: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
Next by thread: Re: [PATCH net-next v2] net: fix signedness bug in skb_splice_from_iter()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]