Re: [PATCH net-next] net: fix signedness bug in skb_splice_from_iter()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 26, 2023 at 02:17:38PM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 
> >  	while (iter->count > 0) {
> >  		ssize_t space, nr;
> > -		size_t off, len;
> > +		ssize_t len;
> > +		size_t off;
> 
> Good point, but why not just move len onto the preceding line?
> 
>  	while (iter->count > 0) {
> -		ssize_t space, nr;
> -		size_t off, len;
> +		ssize_t space, nr, len;
> +		size_t off;

Sure.  Will do.

regards,
dan carpenter




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux