On Fri, May 26, 2023 at 02:45:54PM +0300, Dan Carpenter wrote: > The "val" variable is used to store error codes from phy_read() so > it needs to be signed for the error handling to work as expected. > > Fixes: 014068dcb5b1 ("net: phy: genphy_loopback: add link speed configuration") LGTM. Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!