On Thu, May 25, 2023 at 08:22:15PM +0800, Dongliang Mu wrote:
> On Thu, May 25, 2023 at 4:12 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> >
> > We need to do some clean up before returning on this error path.
> >
> > Fixes: 0d45a1373e66 ("usb: phy: tahvo: add IRQ check")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Hi Dan,
>
> it seems this patch is already submitted with Yang Li from our mailing
> list. Please refer to:
>
> https://www.spinics.net/lists/linux-usb/msg240531.html
>
Ah, fine. Patches are normally applied on a first come first serve
basis so Yang Li's patch will be applied instead of mine.
I sent my patch based on a different static checker warning that I'm
working on about use after frees. Where we add dev_ data to a list but
don't remove it on the error path.
drivers/usb/phy/phy-tahvo.c:394 tahvo_usb_probe() warn: devm_ variable is still on list 'tu' (see line 360)
regards,
dan carpenter
