The copy_to/from_user() functions should return -EFAULT instead of -EINVAL. Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx> --- fs/coda/upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index cd6a3721f6f6..1517dc3bd592 100644 --- a/fs/coda/upcall.c +++ b/fs/coda/upcall.c @@ -510,7 +510,7 @@ int venus_pioctl(struct super_block *sb, struct CodaFid *fid, /* get the data out of user space */ if (copy_from_user((char *)inp + (long)inp->coda_ioctl.data, data->vi.in, data->vi.in_size)) { - error = -EINVAL; + error = -EFAULT; goto exit; } -- 2.30.2