On Sat, May 06, 2023 at 01:06:22PM +0200, Simon Horman wrote: > On Sat, May 06, 2023 at 05:44:28PM +0800, wuych wrote: > > Pointer variables of void * type do not require type cast. > > > > Signed-off-by: wuych <yunchuan@xxxxxxxxxxxx> > > Hi, > > this looks good, but a few things to improve: > > * Did you miss the instance in dpaa2_dbg_bp_show() > * For networking patches, please set the target tree in the subject. > As this is not a fix it should be 'net-next' (if it was a fix it would be > 'net') > [PATCH net-next v2] ... > * As per the form letter below, -net-next is currently closed, > so please repost after May 8th. > * I think the subject prefix should be dpaa2-eth: > [PATCH net-next v2] dpaa2: ... > * I think the patch subject could be a bit clearer > [PATCH net-next v2] dpaa2: Remove unnecessary cast of void pointers Plus, another thing to consider is to take seriously feedback for other patches https://lore.kernel.org/netdev/19409d2b4222b3a5c6fc0cedbfa7844b6eb3440f.camel@xxxxxxxxxx/ Thanks
