On Thu, May 04, 2023 at 06:02:53PM +0800, wuych wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <yunchuan@xxxxxxxxxxxx>
...
> @@ -378,7 +378,7 @@ static int hw_atl2_hw_init_tx_path(struct aq_hw_s *self)
>
> static void hw_atl2_hw_init_new_rx_filters(struct aq_hw_s *self)
> {
> - struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
> + struct hw_atl2_priv *priv = self->priv;
> u8 *prio_tc_map = self->aq_nic_cfg->prio_tc_map;
> u16 action;
> u8 index;
While you are here, and seeing as you need to repost this for net-next
anyway: could you adjust the order of the lines above to observe reverse
xmas tree - longest line to shortest - for local variable declarations
in networking code?
...
> @@ -539,7 +539,7 @@ static int hw_atl2_hw_init(struct aq_hw_s *self, const u8 *mac_addr)
> [AQ_HW_IRQ_MSIX] = { 0x20000022U, 0x20000026U },
> };
>
> - struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
> + struct hw_atl2_priv *priv = self->priv;
> struct aq_nic_cfg_s *aq_nic_cfg = self->aq_nic_cfg;
> u8 base_index, count;
> int err;
Ditto.
...
