On Thu, 2023-04-27 at 09:39 +0800, Su Hui wrote: > From: Suhui <suhui@xxxxxxxxxxxx> > > No need cast (void*) to (struct seq_file*) or (struct tpm_chip*). > > Signed-off-by: Suhui <suhui@xxxxxxxxxxxx> > --- > drivers/char/tpm/eventlog/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c > index 8512ec76d526..df6eb8167e30 100644 > --- a/drivers/char/tpm/eventlog/common.c > +++ b/drivers/char/tpm/eventlog/common.c > @@ -55,8 +55,8 @@ static int tpm_bios_measurements_open(struct inode *inode, > static int tpm_bios_measurements_release(struct inode *inode, > struct file *file) > { > - struct seq_file *seq = (struct seq_file *)file->private_data; > - struct tpm_chip *chip = (struct tpm_chip *)seq->private; > + struct seq_file *seq = file->private_data; > + struct tpm_chip *chip = seq->private; > > put_device(&chip->dev); > And not enough value to remove casting as an independent change. In future please check with scripts/get_maintainers.pl that you have all the mailing lists required. In this case you are missing linux-kernel and linux-integrity. BR, Jarkko