On Fri, Apr 21, 2023 at 11:48:43AM +0000, Ping-Ke Shih wrote: > On Fri, 2023-04-21 at 13:44 +0300, Dan Carpenter wrote: > > > > The if statement is reversed so it will not record the chip version. > > This was detected using Smatch: > > > > drivers/net/wireless/realtek/rtw89/core.c:3593 rtw89_read_chip_ver() > > error: uninitialized symbol 'val'. > > I use smatch to check our driver regularly, but I can't find this error. > With the latest version v0.5.0-8321-g556064ca, I still can't find it. > Do I need to specify additional arguments? Thanks. > You need the cross function database (which takes like 9 hours to build). ~/smatch/smatch_scripts/build_kernel_data.sh regards, dan carpenter
