On Tue, Apr 18, 2023 at 12:39:43PM +0300, Dan Carpenter wrote: > On Tue, Apr 18, 2023 at 10:30:01AM +0300, Dan Carpenter wrote: > > I have some unpublished Smatch stuff which tries to track "variable x > > is in terms of bit units or byte units etc." I will try to make a > > static checker rule for this. > > Attached. It prints a warning like this: > > drivers/net/ethernet/broadcom/cnic.c:667 cnic_init_id_tbl() warn: allocating units of longs instead of bytes 'test_var' > > I'll test it out tonight. It didn't find any bugs. (Which is hardly surprising because most would be caught in testing). No false postives either. I imagine that people will introduce bugs like this in the future and now we'll see it when that happens. regards, dan carpenter
