Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <error27@xxxxxxxxx>
Subject: Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Apr 2023 08:13:17 -0700
Cc: Qu Wenruo <wqu@xxxxxxxx>, Chris Mason <clm@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <3174f3bc-f83f-4009-b062-45eadb5c73d6@kili.mountain>
References: <3174f3bc-f83f-4009-b062-45eadb5c73d6@kili.mountain>

On Thu, Apr 06, 2023 at 11:56:44AM +0300, Dan Carpenter wrote:
> It's just always better to use kcalloc() instead of open coding the
> +	stripe->csums = kcalloc((BTRFS_STRIPE_LEN >> fs_info->sectorsize_bits),

The inner braces can and should go away now.

Follow-Ups:
- Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
  - From: David Sterba

References:
- [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
Next by Date: Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
Previous by thread: Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
Next by thread: Re: [PATCH] btrfs: scrub: use safer allocation function in init_scrub_stripe()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux