On Wed, 22 Mar 2023, Dan Carpenter wrote: > This bug is basically harmless at runtime because of the surrounding lines. > Still the fwnode_property_count_u32() function returns negative error codes > so storing them in an unsigned int will not work. > > Fixes: 96a2e242a5dc ("leds: flash: Add driver to support flash LED module in QCOM PMICs") > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > --- > The patch prefix on this was slightly tricky. Ideally when people add a > new driver the patch which adds the driver would use the patch prefix > for the driver instead of the subsystem: > > Not ideal: [PATCH] leds: Add new driver for QWERTY > Ideal: [PATCH] leds: qwerty: Add new driver That tends not to happen in my experience and I'm fine with it. This precedence is usually set by the second commit. > drivers/leds/flash/leds-qcom-flash.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]