On Sat, Mar 18, 2023 at 08:43:04PM +0100, Markus Elfring wrote:
> Date: Sat, 18 Mar 2023 20:30:12 +0100
>
> The label “error” was used to jump to another pointer check despite of
> the detail in the implementation of the function “siw_accept_newconn”
> that it was determined already that corresponding variables contained
> still null pointers.
>
> 1. Use more appropriate labels instead.
>
> 2. Delete two questionable checks.
>
> 3. Omit extra initialisations (for the variables “new_cep” and “new_s”)
> which became unnecessary with this refactoring.
>
> This issue was detected by using the Coccinelle software.
>
> Fixes: 6c52fdc244b5ccc468006fd65a504d4ee33743c7 ("rdma/siw: connection management")
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/sw/siw/siw_cm.c | 32 ++++++++++++++----------------
> 1 file changed, 15 insertions(+), 17 deletions(-)
Please read Documentation/process/submitting-patches.rst and resubmit.
Your patch is not valid.
Thanks
