Hi Lukas, Mark, On Tue, 14 Mar 2023 09:17:18 +0100 Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > On Tue, Mar 14, 2023 at 8:57 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > > > > Hi Lukas, > > > > On Tue, 14 Mar 2023 08:21:50 +0100 > > Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > > > > > Dear Herve, > > > > > > In your patch below, you added the config CPM_QMC which depends on the > > > non-existing config SOC_FSL: > > > > > > https://lore.kernel.org/r/20230217145645.1768659-7-herve.codina@xxxxxxxxxxx > > > > > > Up to my knowledge, the config SOC_FSL never existed in the mainline > > > tree. Is this dependency really required or can the expression simply > > > be reduced to COMPILE_TEST and we drop the dependency to SOC_FSL? > > > > > > Note: This patch has now shown up in linux-next with commit > > > 3178d58e0b97. Currently, it would not be possible to compile test this > > > driver, as the dependency on SOC_FSL is never met. > > > > > > > > > Best regards, > > > > > > Lukas > > > > My bad :( > > > > The dependency must be FSL_SOC instead of SOC_FSL. > > Herve, are you going to send a quick fix to your patch or ask Mark if > your original patch can simply be replaced with a new one with this > change added? I have just sent a quick fix. https://lore.kernel.org/linux-kernel/20230314082157.137176-1-herve.codina@xxxxxxxxxxx/ Mark, it can be squashed with 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC") Regards Hervé > > Lukas > > > I mean: > > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > > index f90cfdf0c763..7268c2fbcbc1 100644 > > --- a/drivers/soc/fsl/qe/Kconfig > > +++ b/drivers/soc/fsl/qe/Kconfig > > @@ -47,7 +47,7 @@ config CPM_TSA > > config CPM_QMC > > tristate "CPM QMC support" > > depends on OF && HAS_IOMEM > > - depends on CPM1 || (SOC_FSL && COMPILE_TEST) > > + depends on CPM1 || (FSL_SOC && COMPILE_TEST) > > depends on CPM_TSA > > help > > Freescale CPM QUICC Multichannel Controller > > > > > > > > -- > > Hervé Codina, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com
