Re: [PATCH] i2c: gxp: fix an error code in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <error27@xxxxxxxxx>
Subject: Re: [PATCH] i2c: gxp: fix an error code in probe
From: "Hawkins, Nick" <nick.hawkins@xxxxxxx>
Date: Mon, 27 Feb 2023 15:30:07 +0000
Accept-language: en-US
Cc: Joel Stanley <joel@xxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, "linux-i2c@xxxxxxxxxxxxxxx" <linux-i2c@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <Y/yAqRlSTN5VygUy@kili>
References: <Y/yAqRlSTN5VygUy@kili>
User-agent: Microsoft-MacOutlook/16.70.23021201

> This is passing IS_ERR() instead of PTR_ERR() so instead of an error
> code it prints and returns the number 1.


> Fixes: 4a55ed6f89f5 ("i2c: Add GXP SoC I2C Controller")
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx <mailto:error27@xxxxxxxxx>>

Looks good to me.

Reviewed-by: Nick Hawkins <nick.hawkins@xxxxxxx>

References:
- [PATCH] i2c: gxp: fix an error code in probe
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
Next by Date: Re: [PATCH] fbdev: chipsfb: Fix error codes in chipsfb_pci_init()
Previous by thread: [PATCH] i2c: gxp: fix an error code in probe
Next by thread: Re: [PATCH] i2c: gxp: fix an error code in probe
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux