Re: [bug report] net/sched: cls_api: Support hardware miss to tc action

[Matthew Wilcox <willy@xxxxxxxxxxxxx>]

On Mon, Feb 27, 2023 at 04:54:22PM +0300, Dan Carpenter wrote:
>     100         err = xa_alloc_cyclic(&tcf_exts_miss_cookies_xa, &n->miss_cookie_base,
>     101                               n, xa_limit_32b, &next, GFP_KERNEL);
> --> 102         if (err)
> 
> xa_alloc_cyclic() returns 1 if it succeeds after wrapping.  I don't
> know if that applies here, but I feel like this check would be better as
> "if (err < 0)".

Smatch is correct, it should be err < 0.