Re: [PATCH] wifi: mt76: mt7915: unlock on error in mt7915_thermal_temp_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Drop the lock before returning -EINVAL.
> 
> Fixes: ecaccdae7a7e ("wifi: mt76: mt7915: rework mt7915_thermal_temp_store()")
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>

> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> index 1ab768feccaa..728150b35537 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> @@ -89,6 +89,7 @@ static ssize_t mt7915_thermal_temp_store(struct device *dev,
>  	     val < phy->throttle_temp[MT7915_CRIT_TEMP_IDX])) {
>  		dev_err(phy->dev->mt76.dev,
>  			"temp1_max shall be greater than temp1_crit.");
> +		mutex_unlock(&phy->dev->mt76.mutex);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.39.1
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux