Re: [PATCH] spi: bcmbca-hsspi: Fix error code in probe() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <error27@xxxxxxxxx>, William Zhang <william.zhang@xxxxxxxxxxxx>
Subject: Re: [PATCH] spi: bcmbca-hsspi: Fix error code in probe() function
From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Wed, 15 Feb 2023 09:47:39 -0800
Cc: Kursad Oney <kursad.oney@xxxxxxxxxxxx>, Jonas Gorski <jonas.gorski@xxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Anand Gore <anand.gore@xxxxxxxxxxxx>, Rafał Miłecki <rafal@xxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <Y+zmrNJ9zjNQpzWq@kili>
References: <Y+zmrNJ9zjNQpzWq@kili>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/15/23 06:05, Dan Carpenter wrote:

This code accidentally returns success instead of a negative error code.

Fixes: a38a2233f23b ("spi: bcmbca-hsspi: Add driver for newer HSSPI controller")
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>


Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian

References:
- [PATCH] spi: bcmbca-hsspi: Fix error code in probe() function
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT
Next by Date: Re: [PATCH] spi: synquacer: Fix timeout handling in synquacer_spi_transfer_one()
Previous by thread: [PATCH] spi: bcmbca-hsspi: Fix error code in probe() function
Next by thread: Re: [PATCH] spi: bcmbca-hsspi: Fix error code in probe() function
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux