Re: [PATCH net-next] net: phy: Uninitialized variables in yt8531_link_change_notify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 15, 2023 at 09:51:56AM +0800, Frank Sae wrote:
> 
> 
> On 2023/2/14 23:48, Dan Carpenter wrote:
> 
> > @@ -1534,9 +1534,9 @@ static void yt8531_link_change_notify(struct phy_device *phydev)
> >  {
> >  	struct device_node *node = phydev->mdio.dev.of_node;
> >  	bool tx_clk_adj_enabled = false;
> > -	bool tx_clk_1000_inverted;
> > -	bool tx_clk_100_inverted;
> > -	bool tx_clk_10_inverted;
> > +	bool tx_clk_1000_inverted = false;
> > +	bool tx_clk_100_inverted = false;
> > +	bool tx_clk_10_inverted = false;
> 
> Thanks, please keep reverse christmas tree.
> 

Right.  Good point.

regards,
dan carpenter




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux