On Tue, Feb 14, 2023 at 06:49:03PM +0300, Dan Carpenter wrote: > This condition needs to match the previous "if (epcp->state == LISTEN) {" > exactly to avoid a NULL dereference of either "listen_ep" or "ep". The > problem is that "epcp" has been re-assigned so just testing > "if (epcp->state == LISTEN) {" a second time is not sufficient. > > Fixes: 116aeb887371 ("iw_cxgb4: provide detailed provider-specific CM_ID information") > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > --- > >From static analysis, not from testing. It's possible that the current > code works but this change makes it more Obviously Correct[tm]. > Oops. I accidentally sent this twice. Sorry! regards, dan carpenter