Re: [PATCH] gpio: mxc: Unlock on error path in mxc_flip_edge()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/24/23 16:20, Dan Carpenter wrote:
We recently added locking to this function but one error path was
over looked.  Drop the lock before returning.

Fixes: e5464277625c ("gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock")
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
---
  drivers/gpio/gpio-mxc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 6f673b2f2a1b..9d0cec4b82a3 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -249,10 +249,11 @@ static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio)
  	} else {
  		pr_err("mxc: invalid configuration for GPIO %d: %x\n",
  		       gpio, edge);
-		return;
+		goto unlock;
  	}
  	writel(val | (edge << (bit << 1)), reg);
+unlock:
  	raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags);
  }

Acked-by: Marek Vasut <marex@xxxxxxx>

Thanks !



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux