Re: [PATCH] firmware: arm_scmi: Clean up a return statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended.  Also it's
> cleaner to return zero explicitly instead of ret.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
>  drivers/firmware/arm_scmi/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
>  				if (ret)
>  					goto clear_dev_req_notifier;
>  
> -				/* Bail out anyway when coex enabled */
> -				return ret;
> +				/* Bail out anyway when coex disabled. */
> +				return 0;
>  			}
>  
>  			/* Coex enabled, carry on in any case. */
> -- 

Indeed.

Thanks,
Cristian



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux