Re: [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Peter Lafreniere <peter@xxxxxxxx> writes:

> To avoid confusion, it is best to only define CONFIG_* macros in Kconfig
> files. Here we change the name of one define, which causes no change to
> functionality.
>
> Signed-off-by: Peter Lafreniere <peter@xxxxxxxx>
> ---

[...]

> --- a/drivers/net/wireless/rsi/rsi_hal.h
> +++ b/drivers/net/wireless/rsi/rsi_hal.h
> @@ -69,7 +69,7 @@
>  #define EOF_REACHED			'E'
>  #define CHECK_CRC			'K'
>  #define POLLING_MODE			'P'
> -#define CONFIG_AUTO_READ_MODE		'R'
> +#define CONFIGURE_AUTO_READ_MODE	'R'

I would prefer to add a prefix instead, for example
RSI_CONFIG_AUTO_READ_MODE or something like that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux