Le 10/01/2023 à 08:19, Vineet Gupta a écrit :
On 1/8/23 11:04, Christophe JAILLET wrote:
In an attempt to simplify some includes in <include/dcache.h>, it
appeared, when compiling fs/ecryptfs/dentry.c, that
<linux/bit_spinlock.h>
was relying on other includes to get the definition of cpu_relax().
(see [1])
It broke on arc.
It its just ARC that broke, maybe we can do something there ?
Hi,
It is all what build-bots have spotted so far :)
I don't think that "fixing" it in ARC is the right approach, unless I
missed something.
<linux/bit_spinlock.h> does use cpu_relax(), so it should include what
is need for that, and not rely on other black magic.
CJ
Include <asm/processor.h> in <linux/bit_spinlock.h> to fix the issue.
This will help remove some un-needed includes from <include/dcache.h>.
[1]: https://lore.kernel.org/all/202301082130.LXMj5qkD-lkp@xxxxxxxxx/
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
Not sure who to send this to.
get_maintainer.pl is of no help, and the file is untouched from a too
long
time.
Greg? Dan? Any pointer?
---
include/linux/bit_spinlock.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h
index bbc4730a6505..d0fd2a7afca2 100644
--- a/include/linux/bit_spinlock.h
+++ b/include/linux/bit_spinlock.h
@@ -2,6 +2,7 @@
#ifndef __LINUX_BIT_SPINLOCK_H
#define __LINUX_BIT_SPINLOCK_H
+#include <asm/processor.h>
#include <linux/kernel.h>
#include <linux/preempt.h>
#include <linux/atomic.h>
