On 2023/1/5 18:53, Dan Carpenter wrote:
This code accidentally returns success instead of -ENOMEM.
Fixes: 7cc7646b4b24 ("scsi: libsas: Factor out sas_ata_add_dev()")
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
---
drivers/scsi/libsas/sas_ata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 177cdaef3cad..f5e1c24f54ca 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -716,7 +716,7 @@ int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *phy,
rphy = sas_end_device_alloc(phy->port);
if (!rphy)
- return ret;
+ return -ENOMEM;
Hi Dan,
Good catch, thanks for the fix.
Reviewed-by: Jason Yan <yanaijie@xxxxxxxxxx>
