If an error occurs after a successful pwm_enable() call, it must be undone by a corresponding pwm_disable(), as already done in the remove function. Fixes: 5b143d2a6ede ("bus: add driver for the Technologic Systems NBUS") Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> --- Not sure if we need the mutex_lock()/mutex_unlock() that is in the remove function. --- drivers/bus/ts-nbus.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 38c886dc2ed6..ed568061ba6b 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -324,11 +324,16 @@ static int ts_nbus_probe(struct platform_device *pdev) ret = of_platform_populate(dev->of_node, NULL, NULL, dev); if (ret < 0) - return ret; + goto err_disable_pwm; dev_info(dev, "initialized\n"); return 0; + +err_disable_pwm: + pwm_disable(pwm); + return ret; + } static int ts_nbus_remove(struct platform_device *pdev) -- 2.34.1