On Sun, Dec 04, 2022 at 02:47:13PM +0200, Leon Romanovsky wrote:
> On Fri, Dec 02, 2022 at 12:58:26PM +0300, Dan Carpenter wrote:
> > The pp->indir[0] value comes from the user. It is passed to:
> >
> > if (cpu_online(pp->rxq_def))
> >
> > inside the mvneta_percpu_elect() function. It needs bounds checkeding
> > to ensure that it is not beyond the end of the cpu bitmap.
> >
> > Fixes: cad5d847a093 ("net: mvneta: Fix the CPU choice in mvneta_percpu_elect")
> > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> > ---
> > drivers/net/ethernet/marvell/mvneta.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> I would expect that ethtool_copy_validate_indir() will prevent this.
>
Huh... Sort of, but in the strictest sense, no. mvneta_ethtool_get_rxnfc()
sets the cap at 8 by default or an unvalidated module parameter.
regards,
dan carpenter
