Hi Christophe, On Fri, Dec 02, 2022 at 10:13:36PM +0100, Christophe JAILLET wrote: > <linux/prandom.h> uses DO_ONCE(). So it should include <linux/once.h> > directly. > > On the contrary, <linux/random.h> doesn't use functionalities from > <linux/once.h>, so it should be removed. > > All this is true since commit c0842fbc1b18 ("random32: move the > pseudo-random 32-bit definitions to prandom.h") > > Move the #include <linux/once.h> in the right file. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Thanks, applied for now as: https://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git/commit/?id=1ea746beac98ad11132b0a9a11978d5cf0a055ef > --- > Let see if build-bots agree with me! Indeed. I've got a few builds of my own going, and so far so good, but we'll learn soon enough if something goes wrong. Jason