Hi Colin, On Mon, Oct 24, 2022 at 04:13:54PM +0100, Colin Ian King wrote: > Variable cnt is just being incremented and it's never used > anywhere else. The variable and the increment are redundant so > remove it. > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > --- > drivers/media/pci/saa7164/saa7164-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c > index d5f32e3ff544..01d75ef2342d 100644 > --- a/drivers/media/pci/saa7164/saa7164-core.c > +++ b/drivers/media/pci/saa7164/saa7164-core.c > @@ -352,7 +352,7 @@ static void saa7164_work_enchandler(struct work_struct *w) > container_of(w, struct saa7164_port, workenc); > struct saa7164_dev *dev = port->dev; > > - u32 wp, mcb, rp, cnt = 0; > + u32 wp, mcb, rp; > > port->last_svc_msecs_diff = port->last_svc_msecs; > port->last_svc_msecs = jiffies_to_msecs(jiffies); > @@ -405,7 +405,6 @@ static void saa7164_work_enchandler(struct work_struct *w) > > saa7164_work_enchandler_helper(port, rp); > port->last_svc_rp = rp; > - cnt++; > > if (rp == mcb) > break; > @@ -429,7 +428,7 @@ static void saa7164_work_vbihandler(struct work_struct *w) > container_of(w, struct saa7164_port, workenc); > struct saa7164_dev *dev = port->dev; > > - u32 wp, mcb, rp, cnt = 0; > + u32 wp, mcb, rp; > > port->last_svc_msecs_diff = port->last_svc_msecs; > port->last_svc_msecs = jiffies_to_msecs(jiffies); > @@ -481,7 +480,6 @@ static void saa7164_work_vbihandler(struct work_struct *w) > > saa7164_work_enchandler_helper(port, rp); > port->last_svc_rp = rp; > - cnt++; > > if (rp == mcb) > break; > -- > 2.37.3 > Looks good to me. Reviewed-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx> -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@xxxxxxxxxxxxxxxxxxxx __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@xxxxxxxxxxxxxxxxxxxx www.amarulasolutions.com
