The "ret" variable is zero at this point. No need to check. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/thermal/thermal_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c index 8d7b25ab67c2..af3dced054f3 100644 --- a/drivers/thermal/thermal_sysfs.c +++ b/drivers/thermal/thermal_sysfs.c @@ -190,7 +190,7 @@ trip_point_hyst_show(struct device *dev, struct device_attribute *attr, if (ret) return ret; - return ret ? ret : sprintf(buf, "%d\n", trip.hysteresis); + return sprintf(buf, "%d\n", trip.hysteresis); } static ssize_t -- 2.35.1