Hi Usama, On 10/04, Muhammad Usama Anjum wrote:
Don't initialize the rc as its value is being overwritten before its use.
Being bitten by an unitialized variable bug as recent as 2 days ago, I'd say this is a step backwards from the "best practices" POV.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> --- fs/cifs/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 0600f0a07628..2bf43c892ae6 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -879,7 +879,7 @@ SMB2_negotiate(const unsigned int xid, struct smb2_negotiate_rsp *rsp; struct kvec iov[1]; struct kvec rsp_iov; - int rc = 0; + int rc; int resp_buftype; int blob_offset, blob_length; char *security_blob; -- 2.30.2
Cheers, Enzo
