On 9/30/22 10:46, Huacai Chen wrote:
On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:
On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote:
Hi, Lukas,
Thank you for your patch, it is queued for loongarch-next, and may be
squashed to another patch with your S-o-B if you have no objections.
Huacai
Feel free to squash as you see fit. I cannot recall sending something
specific for loongarch-next, though.
Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
patch [1]. :)
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
Hi, I have to disagree with you in this case, you are mixing multiple
logical changes into one commit. Although all the commits are touching
the same Kconfig defaults file it doesn't mean they can be
unconditionally squashed. Especially when you have apparently dropped
Lukas' detailed explanation regarding the cleanups with one single
"Remove obsolete config options" sentence...
As you haven't created the tag and PR'd yet, I'd suggest you fix the
branch and just make the commits separate. At the very least please
don't delete Lukas' link reference regarding this round of overall
Kconfig cleanup effort.
--
WANG "xen0n" Xuerui
Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
