On 22/09/2022 14:21, Dan Carpenter wrote:
> These two error paths need to call of_node_put(child_node) before
> returning.
>
> Fixes: edd473d4293a ("phy: ti: phy-j721e-wiz: add support for j7200-wiz-10g")
> Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>
> ---
> drivers/phy/ti/phy-j721e-wiz.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 20af142580ad..438ccce3d1bf 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1400,7 +1400,8 @@ static int wiz_probe(struct platform_device *pdev)
> if (IS_ERR(wiz->scm_regmap)) {
> if (wiz->type == J7200_WIZ_10G) {
> dev_err(dev, "Couldn't get ti,scm regmap\n");
> - return -ENODEV;
> + ret = -ENODEV;
> + goto err_addr_to_resource;
> }
>
> wiz->scm_regmap = NULL;
> @@ -1450,7 +1451,7 @@ static int wiz_probe(struct platform_device *pdev)
>
> ret = wiz_get_lane_phy_types(dev, wiz);
> if (ret)
> - return ret;
> + goto err_addr_to_resource;
>
> wiz->dev = dev;
> wiz->regmap = regmap;
cheers,
-roger
