在 2022/9/20 5:09, Jakub Kicinski 写道:
On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: fef2998203e1 ("net: altera: tse: convert to phylink") Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: Sun Ke <sunke32@xxxxxxxxxx>You must CC Maxime, who authored the change under Fixes, and is most likely the best person to give us a review. Please repost with the CC fixed.
OK. Thanks, Sun Ke
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index 89ae6d1623aa..3cf409bdb283 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev) priv->phy_iface, &alt_tse_phylink_ops); if (IS_ERR(priv->phylink)) { dev_err(&pdev->dev, "failed to create phylink\n"); + ret = PTR_ERR(priv->phylink); goto err_init_phy; }.
