Le 18/09/2022 à 10:03, kernel test robot a écrit :
Hi Christophe,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on next-20220916]
[cannot apply to linus/master v6.0-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/misc-microchip-pci1xxxx-Fix-the-error-handling-path-of-gp_aux_bus_probe/20220918-143022
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git ceecbbddbf549fe0b7ffa3804a6e255b3360030f
config: xtensa-randconfig-r022-20220918
compiler: xtensa-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/089c1639fdebdad9be8de56c1546308eac15747d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christophe-JAILLET/misc-microchip-pci1xxxx-Fix-the-error-handling-path-of-gp_aux_bus_probe/20220918-143022
git checkout 089c1639fdebdad9be8de56c1546308eac15747d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/misc/mchp_pci1xxxx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function 'gp_aux_bus_probe':
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:35:13: warning: variable 'irq' set but not used [-Wunused-but-set-variable]
35 | int irq, retval;
| ^~~
vim +/irq +35 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
[...]
75
76 retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
77 if (retval < 0)
78 goto err_aux_dev_del_0;
79
80 retval = pci_irq_vector(pdev, 0);
81 if (retval < 0)
82 goto err_aux_dev_del_0;
83 irq = retval;
We save the irq number here...
84
85 aux_bus->aux_device_wrapper[1] = kzalloc(sizeof(*aux_bus->aux_device_wrapper[1]),
86 GFP_KERNEL);
87 if (!aux_bus->aux_device_wrapper[1]) {
88 retval = -ENOMEM;
89 goto err_aux_dev_del_0;
90 }
91
92 retval = ida_alloc(&gp_client_ida, GFP_KERNEL);
93 if (retval < 0) {
94 kfree(aux_bus->aux_device_wrapper[1]);
95 goto err_aux_dev_del_0;
96 }
97
98 aux_bus->aux_device_wrapper[1]->aux_dev.name = aux_dev_gpio_name;
99 aux_bus->aux_device_wrapper[1]->aux_dev.dev.parent = &pdev->dev;
100 aux_bus->aux_device_wrapper[1]->aux_dev.dev.release = gp_auxiliary_device_release;
101 aux_bus->aux_device_wrapper[1]->aux_dev.id = retval;
102
103 aux_bus->aux_device_wrapper[1]->gp_aux_data.region_start = pci_resource_start(pdev, 0);
104 aux_bus->aux_device_wrapper[1]->gp_aux_data.region_length = pci_resource_end(pdev, 0);
105
106 pdev->irq = retval;
... then this should be:
pdev->irq = irq;
here.
I'll send a v2 in a few days.
Let see first if we get some other feedback.
CJ
