On Fri, Sep 09, 2022 at 02:25:45PM +0800, Yu Zhe wrote: > The platform_get_irq_byname() function returns negative error codes on error, > check it. > > Signed-off-by: Yu Zhe <yuzhe@xxxxxxxxxxxx> > --- > drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c > index c131d8118489..d985056db6c2 100644 > --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c > +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c > @@ -705,6 +705,8 @@ static int bcm4908_enet_probe(struct platform_device *pdev) > return netdev->irq; > > enet->irq_tx = platform_get_irq_byname(pdev, "tx"); > + if (enet->irq_tx < 0) > + return enet->irq_tx; > If you read the driver, then you will see that this is deliberate. Search for irq_tx and read the comments. I'm not a subsystem expert so I don't know if this an ideal way to write the code, but it's done deliberately so please don't change it unless you can test it. regards, dan carpenter
