On 2022/09/11 21:41, Arnd Bergmann wrote: > On Sun, Sep 11, 2022, at 1:54 PM, Damien Le Moal wrote: >> On 2022/09/09 20:31, Arnd Bergmann wrote: >>> >>> config PATA_PLATFORM >>> - tristate "Generic platform device PATA support" >>> - depends on EXPERT || PPC || HAVE_PATA_PLATFORM >>> + tristate "Generic platform device PATA support" if EXPERT || HAVE_PATA_PLATFORM >> >> Shouldn't this be: >> >> tristate "Generic platform device PATA support" if EXPERT || PPC >> >> ? >> >> And while at it, it would be nice to add "|| COMPILE_TEST" too. > > The idea was that this can be selected by CONFIG_PATA_OF_PLATFORM > in any configuration that has CONFIG_OF enabled. Since PPC > has CONFIG_OF enabled unconditionally, there is no need to > make this option visible separately. > > Same for compile-testing: since CONFIG_OF can be enabled on > any architecture, PATA_OF_PLATFORM is already covered by > allmodconfig builds anywhere. The separate HAVE_PATA_PLATFORM > is only needed for machines that want the non-OF pata-platform > module (sh, m68k-mac, mips-sibyte arm-s3c-simtec). Got it. Thanks for the details. > > Arnd -- Damien Le Moal Western Digital Research
