[bug report] net: ngbe: Add build support for ngbe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Mengyuan Lou,

The patch e79e40c83b9f: "net: ngbe: Add build support for ngbe" from
Aug 26, 2022, leads to the following Smatch static checker warning:

	drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown()
	error: uninitialized symbol 'wake'.

drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
    47 static void ngbe_shutdown(struct pci_dev *pdev)
    48 {
    49         bool wake;
    50 
    51         ngbe_dev_shutdown(pdev, &wake);
                                       ^^^^^
Never initialized.

    52 
    53         if (system_state == SYSTEM_POWER_OFF) {
--> 54                 pci_wake_from_d3(pdev, wake);
                                              ^^^^
Uninitalized.

    55                 pci_set_power_state(pdev, PCI_D3hot);
    56         }
    57 }

regards,
dan carpenter



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux