If size < 0; open request will fail, but cachefiles_ondemand_copen return 0. Fix to return a negative error code. Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie") Signed-off-by: Sun Ke <sunke32@xxxxxxxxxx> --- fs/cachefiles/ondemand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c index 1fee702d5529..a31d3ff0ce5f 100644 --- a/fs/cachefiles/ondemand.c +++ b/fs/cachefiles/ondemand.c @@ -161,6 +161,7 @@ int cachefiles_ondemand_copen(struct cachefiles_cache *cache, char *args) if (!IS_ERR_VALUE(size)) size = -EINVAL; req->error = size; + ret = -EINVAL; goto out; } -- 2.31.1