Unlock on this error path before returning. Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/cxl/core/hdm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c index d1d2caea5c62..873c07386064 100644 --- a/drivers/cxl/core/hdm.c +++ b/drivers/cxl/core/hdm.c @@ -605,6 +605,7 @@ static int cxl_decoder_commit(struct cxl_decoder *cxld) rc = cxlsd_set_targets(cxlsd, &targets); if (rc) { + up_read(&cxl_dpa_rwsem); dev_dbg(&port->dev, "%s: target configuration error\n", dev_name(&cxld->dev)); goto err; -- 2.35.1