On Fri, Aug 05, 2022 at 06:35:01PM +0000, Michael Kelley (LINUX) wrote:
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Sent: Sunday, July 31, 2022 1:02 PM
> >
> > hyperv_setup_vram() calls vmbus_allocate_mmio().
> > This must be undone in the error handling path of the probe, as already
> > done in the remove function.
> >
> > This patch depends on commit a0ab5abced55 ("drm/hyperv : Removing the
> > restruction of VRAM allocation with PCI bar size").
> > Without it, something like what is done in commit e048834c209a
> > ("drm/hyperv: Fix device removal on Gen1 VMs") should be done.
>
> Should the above paragraph be below the '---' as a comment, rather than
> part of the commit message? It's more about staging instructions than a
> long-term record of the actual functional/code change.
>
I don't think this paragraph needs to be in the final commit message.
> >
> > Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video device")
>
> I wonder if the Fixes: dependency should be on a0ab5abced55. As you noted,
> this patch won't apply cleanly on stable kernel versions that lack that commit,
> so we'll need a separate patch for stable if we want to make the fix there.
>
I think a0ab5abced55 is more appropriate.
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> All that said, the fix looks good, so
>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
I made the two changes listed above and applied this patch to
hyperv-fixes.
Thanks,
Wei.
