On 04.08.22 10:11, Dan Carpenter wrote:
Hello Dan
> This code tries to store -EFAULT in an unsigned int. The
> xenbus_file_read() function returns type ssize_t so the negative value
> is returned as a positive value to the user.
>
> This change forces another change to the min() macro. Originally, the
> min() macro used "unsigned" type which checkpatch complains about. Also
> unsigned type would break if "len" were not capped at MAX_RW_COUNT. Use
> size_t for the min(). (No effect on runtime for the min_t() change).
>
> Fixes: 2fb3683e7b16 ("xen: Add xenbus device driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
I think that patch does correct changes, so
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
[snip]
--
Regards,
Oleksandr Tyshchenko
