Dan Carpenter wrote:
> The ++ needs a match -- on the clean up path. If the p->nr_targets
> value gets to be more than 16 it leads to uninitialized data in
> cxl_port_setup_targets().
>
> drivers/cxl/core/region.c:995 cxl_port_setup_targets() error: uninitialized symbol 'eiw'.
>
> Fixes: 27b3f8d13830 ("cxl/region: Program target lists")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/cxl/core/region.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index c80932bca667..0450354bff4d 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -1217,12 +1217,14 @@ static int cxl_region_attach(struct cxl_region *cxlr,
> if (p->nr_targets == p->interleave_ways) {
> rc = cxl_region_setup_targets(cxlr);
> if (rc)
> - goto err;
> + goto err_decrement;
> p->state = CXL_CONFIG_ACTIVE;
> }
>
> return 0;
>
> +err_decrement:
> + p->nr_targets--;
Yes, looks good.
