Applied. Thanks! Alex On Tue, Jul 26, 2022 at 11:16 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The "ret" variable needs to be signed for the error handling to work. > > Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > index d66e3cd64ebd..a0154a5f7183 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c > @@ -569,7 +569,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux, > unsigned char rc_cmd = 0; > unsigned char rc_result = 0xFF; > unsigned char i = 0; > - uint8_t ret = 0; > + int ret; > > if (is_write_cmd) { > // write rc data > -- > 2.35.1 >