Re: [PATCH] libbpf: fix str_has_sfx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@xxxxxxxxxxxxx>:

On Tue, 19 Jul 2022 12:53:01 +0300 you wrote:
> The return from strcmp() is inverted so the it returns true instead
> of false and vise versa.
> 
> Fixes: a1c9d61b19cb ("libbpf: Improve library identification for uprobe binary path resolution")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Spotted during review.  *cmp() functions should always have a comparison
> to zero.
> 	if (strcmp(a, b) < 0) {  <-- means a < b
> 	if (strcmp(a, b) >= 0) { <-- means a >= b
> 	if (strcmp(a, b) != 0) { <-- means a != b
> etc.
> 
> [...]

Here is the summary with links:
  - libbpf: fix str_has_sfx()
    https://git.kernel.org/bpf/bpf-next/c/14229b8153a3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux