On 7/21/22 3:31 PM, Leon Romanovsky wrote: > On Wed, Jul 20, 2022 at 09:58:24AM +0800, Cheng Xu wrote: >> >> >> On 7/19/22 11:36 PM, Christophe JAILLET wrote: >>> Le 19/07/2022 à 15:01, Dan Carpenter a écrit : >>>> On Tue, Jul 19, 2022 at 09:54:34AM -0300, Jason Gunthorpe wrote: >>>>> On Tue, Jul 12, 2022 at 12:01:10PM +0300, Dan Carpenter wrote: >>>>> >>>>>> Best not to use any auto-formatting tools. They are all bad. >>>>> >>>>> Have you tried clang-format? I wouldn't call it bad.. >>>> >>>> I prefered Christophe's formatting to clang's. ;) >>>> >>>> regards, >>>> dan carpenter >>>> >>>> >>> >>> Hi, >>> >>> (some other files in the same directory also have some checkpatch warning/error) >> >> I just double checked the checkpatch results, Two type warnings reported: >> >> - WARNING: Missing commit description - Add an appropriate one (for patch 0001) >> - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? (for almost all patches except 0001/0011) >> >> For the first warning, the change is very simple: add erdma's >> rdma_driver_id definition, I think the commit title can describe >> all things, and is enough. > > To be clear, our preference is to have commit message in any case, even > for simple changes. > Sorry for this, I didn't know it previously. Before I sent our patches, I reviewed the EFA/SIW's upstreaming history, and siw only has one line commit title for simply changes, I followed. I will update our patches to fix it in a few days, and collect potential feedback of erdma code in linux-next. Thanks, Cheng Xu
