Re: [PATCH] scsi: mpi3mr: unlock on error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: mpi3mr: unlock on error path
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 18 Jul 2022 22:39:33 -0400
Cc: Sathya Prakash Veerichetty <sathya.prakash@xxxxxxxxxxxx>, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>, Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>, Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, mpi3mr-linuxdrv.pdl@xxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <YtVCEsxMU8buuMjP@kili> (Dan Carpenter's message of "Mon, 18 Jul 2022 14:20:50 +0300")
Organization: Oracle Corporation
References: <YtVCEsxMU8buuMjP@kili>

Dan,

> There is some clean up necessary before returning.  Smatch complains:
>
>     drivers/scsi/mpi3mr/mpi3mr_fw.c:4786 mpi3mr_soft_reset_handler()
>     warn: inconsistent returns '&mrioc->reset_mutex'.
>       Locked on  : 4730
>       Unlocked on: 4786

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: mpi3mr: unlock on error path
  - From: Dan Carpenter

Prev by Date: Re: [PATCH 1/3] ublk_drv: fix an IS_ERR() vs NULL check
Next by Date: Re: [PATCH] scsi: mpi3mr: delete a stray tab
Previous by thread: [PATCH] scsi: mpi3mr: unlock on error path
Next by thread: Re: [PATCH] scsi: mpi3mr: unlock on error path
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux