On Thu, Jul 14, 2022 at 03:25:02AM +0000, Ratheesh Kannoth wrote: > Dan, > Thanks !! > > I tried to run smatch tool and could not see any of these errors ? Am I missing any step ? > === > ./smatch-master/smatch_scripts/kchecker drivers/net/ethernet/marvell/octeontx2/ > > CHECK drivers/net/ethernet/marvell/octeontx2/af/rvu_sdp.c > CC drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.o > CHECK drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > AR drivers/net/ethernet/marvell/octeontx2/af/built-in.a > CHECK drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c > CHECK drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c Hm... To see those warnings then you need the cross function DB enabled. It takes forever (over night) to build. ./smatch-master/smatch_scripts/build_kernel_data.sh > > >drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:735 otx2_mbox_alloc_msg_npc_get_secret_key() warn: struct type mismatch 'mbox_msghdr vs npc_get_secret_key_req' > I don't see any issue in the code. > Sorry, this is unpublished Smatch code which was buggy. I have fixed it now. regards, dan carpenter