Re: [PATCH] PCI: endpoint: IS_ERR() vs NULL bug in pci_epf_test_init_dma_chan()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Shunsuke Mie <mie@xxxxxxxxxx>
Subject: Re: [PATCH] PCI: endpoint: IS_ERR() vs NULL bug in pci_epf_test_init_dma_chan()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 12 Jul 2022 10:43:16 +0300
Cc: Kishon Vijay Abraham I <kishon@xxxxxx>, Frank Li <Frank.Li@xxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>, Li Chen <lchen@xxxxxxxxxxxxx>, Manivannan Sadhasivam <mani@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <CANXvt5rK98-cEMgpzopY9POOK8a5=VDib8uKPLgJakOG=hRfwQ@mail.gmail.com>
References: <YsftwaVowtU9/pgn@kili> <CANXvt5rK98-cEMgpzopY9POOK8a5=VDib8uKPLgJakOG=hRfwQ@mail.gmail.com>
User-agent: Mutt/1.9.4 (2018-02-28)

On Mon, Jul 11, 2022 at 02:50:14PM +0900, Shunsuke Mie wrote:
> This patch changes for a tx dma channel. There is a similar problem for a
>  rx one too. The code doesn't cause an error, but it is likely better to
> change to just NULL checking.
> 

Yep.  Thanks.  I will resend.

regards,
dan carpenter

References:
- [PATCH] PCI: endpoint: IS_ERR() vs NULL bug in pci_epf_test_init_dma_chan()
  - From: Dan Carpenter
- Re: [PATCH] PCI: endpoint: IS_ERR() vs NULL bug in pci_epf_test_init_dma_chan()
  - From: Shunsuke Mie

Prev by Date: Re: [PATCH] vfio/mlx5: clean up overflow check
Next by Date: Re: [PATCH 1/2] RDMA/erdma: Use the bitmap API to allocate bitmaps
Previous by thread: Re: [PATCH] PCI: endpoint: IS_ERR() vs NULL bug in pci_epf_test_init_dma_chan()
Next by thread: [PATCH v2] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]