On Wed, Jul 06, 2022 at 01:18:12PM -0300, Jason Gunthorpe wrote: > On Wed, Jul 06, 2022 at 08:51:24AM +0300, Dan Carpenter wrote: > > > > This code was copy and pasted from drivers/vfio/pci/mlx5/main.c, so it > > > should be fixed too > > > > Sure. > > > > I created a static checker warning for this type of thing but it didn't > > catch the issue in drivers/vfio/pci/mlx5/main.c because Smatch says that > > the bug is impossible. Which is true. > > How come it is different? No, it doesn't find either one. I don't think it's a real bug because of the rw_verify_area() thing. But I wrote the check based on noticing it during review just to see if there were similar issues and didn't find anything. regards, dan carpenter
